Force response body update #540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Network.HTTP.Client.Response.getResponse` stores the original request inside a `Response`, but attempts to override its request body with an empty one. This record update was lazy, and a reference to the original request body would persist, causing a space leak. Force the response to WHNF, and use bang patterns to force the Request and ultimately its body to WHNF too.
JackKelly-Bellroy
force-pushed
the
force-response-body-update
branch
from
dee2a38 to
0f91cae
Compare
|
Either approach is fine with me. |
|
We could never prove an improvement in space usage with this PR, so I'm going to close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #538
Draft for now, but keen for comments: do you prefer strict
lets?seq? Bang patterns?We will test this internally before recommending that it gets merged.